fix: address all PR review comments on config-driven rules engine#11
Closed
Copilot wants to merge 1 commit intoconfig-driven-rules-enginefrom
Closed
fix: address all PR review comments on config-driven rules engine#11Copilot wants to merge 1 commit intoconfig-driven-rules-enginefrom
Copilot wants to merge 1 commit intoconfig-driven-rules-enginefrom
Conversation
Copilot
AI
changed the title
[WIP] Refactor config-driven rules engine
fix: address all PR review comments on config-driven rules engine
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five issues flagged in code review on the config-driven rules engine refactor.
Changes
CI / Workflow
apk add --no-cache makestep beforemakecalls — Alpine images ship withoutmakeMakefile
:ZSELinux relabel option is now conditional on Podman being the detected engine; Docker uses a plain bind-mountmodules/ukko.js—mailing_listhandleremail.includes('.')tofqdn.includes('.')(domain portion only), preventingundefinedsublabels for addresses with dots in the local-part (e.g.user.name@localhost)test/ukko.test.jsendswithtest was a no-op (noendswithrules exist in config); now pushes a temporary rule intry/finallyto exercise the code path deterministicallyFrom-header fallback rule (none exists); replaced with a hard assertion: GitHubFrom+List-Idpresent →githublabel assigned,lists/*absent🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.