Skip to content

ci: fix make not found in node alpine containers#10

Closed
Copilot wants to merge 2 commits intoconfig-driven-rules-enginefrom
copilot/sub-pr-9
Closed

ci: fix make not found in node alpine containers#10
Copilot wants to merge 2 commits intoconfig-driven-rules-enginefrom
copilot/sub-pr-9

Conversation

Copy link

Copilot AI commented Mar 18, 2026

The CI workflow failed on node:*-alpine images because make is not included in the alpine base image, causing all make targets to fail immediately after checkout.

  • Workflow fix: Added apk add --no-cache make step before any make invocations in .github/workflows/node.js.yml

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

T0MASD and others added 2 commits March 18, 2026 13:31
Replaces hardcoded if/else label logic in getLabels() with a
declarative RULES array and HANDLERS object pattern.

- RULES: array of {header, contains/endswith, label, handler, fallback}
- HANDLERS: named functions receiving (message, baseLabel) for dynamic sublabeling
- Fallback rules only fire when no other rules matched
- Added Makefile for containerized testing (node:20-alpine via Podman)
- 19 new tests (38 total), all passing
- Lint clean (0 errors)
- Updated README with config-driven documentation
- Fixed npm start: node app.js instead of node .

Closes #1
@T0MASD T0MASD marked this pull request as ready for review March 18, 2026 11:33
Copilot AI changed the title [WIP] [#1] Refactor config-driven rules engine ci: fix make not found in node alpine containers Mar 18, 2026
Copilot AI requested a review from T0MASD March 18, 2026 11:39
@T0MASD T0MASD force-pushed the config-driven-rules-engine branch from 23accde to ee1ce47 Compare March 18, 2026 11:45
@T0MASD T0MASD closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants