Fix ambiguous overloaded call on SPK::IO::Buffer#20
Open
kingscallop wants to merge 1 commit intoSynxis:spark2from
Open
Fix ambiguous overloaded call on SPK::IO::Buffer#20kingscallop wants to merge 1 commit intoSynxis:spark2from
kingscallop wants to merge 1 commit intoSynxis:spark2from
Conversation
When trying to write a 'size_t' to a SPK::IO::Buffer, the following error happens.
spark/include/Core/IO/SPK_IO_Buffer.h:224:27: error: call of overloaded ‘put(long unsigned int&)’ is ambiguous
224 | buffer.put(value);
| ~~~~~~~~~~^~~~~~~
spark/include/Core/IO/SPK_IO_Buffer.h:76:22: note: candidate: ‘void SPK::IO::Buffer::put(char)’
76 | void put(char c);
| ^~~
spark/include/Core/IO/SPK_IO_Buffer.h:96:22: note: candidate: ‘void SPK::IO::Buffer::put(unsigned char)’
96 | void put(unsigned char c) { put((char)c); }
| ^~~
spark/include/Core/IO/SPK_IO_Buffer.h:97:22: note: candidate: ‘void SPK::IO::Buffer::put(signed char)’
97 | void put(signed char c) { put((char)c); }
etc.
As there is no overload to 'size_t', the patch casts it to unsigned int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to write a 'size_t' to a SPK::IO::Buffer, the following error happens.
As there is no overload to 'size_t', the patch casts it to unsigned int.