Open
Conversation
The function doc, while being exact, can be hard to read. Giving an example clarifies the function's behavior.
Owner
|
I agree that examples help. This one, however, is not very practical or illustrative. It's hard to come up with a good example for this function, especially one not covered by list comprehensions. |
Author
|
I could not come up with any practical example for this function. This example at least allows to understand what the function does; better than no example at all. |
Author
|
Believe it or not, I just found a use case for it at work: metric_functions=[metric_A,metric_B,metric_C]
metrics = funcy.join(funcy.map(funcy.caller(data), metric_functions))Would you be fine with this one? |
Owner
|
This one makes sense :) I was struggling to find anything good too
ср, 10 апр. 2024 г., 21:51 Antoine Gallix ***@***.***>:
… Believe it or not, I just found a use case for it at work:
metric_functions=[metric_A,metric_B,metric_C]metrics = funcy.join(funcy.map(funcy.caller(data), metric_functions))
Would you be fine with this one?
—
Reply to this email directly, view it on GitHub
<#152 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFLR5UDFBILHGIBIOVXWLY4VGWTAVCNFSM6AAAAABFVP2WBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXG43DQNRSGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Author
|
Allright I'll update my PR. I also just thought that the problem above would be resolved as well with: metrics = funcy.join(funcy.juxt(metric_functions)(data))But I guess it's not the point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function doc, while being exact, can be hard to read. Giving an example clarifies the function's behavior.