Open
Conversation
Stypox
requested changes
Mar 15, 2026
Owner
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I feel like #266 should be solved first, and then this PR should reuse the same strategies from that PR. In any case, duplicating the whole contact selection mechanism from the phone skill is a no-go, so please rework this PR to reuse most of the classes of the phone skill.
Owner
There was a problem hiding this comment.
As I already mentioned in the other PRs, LLMs are not good at writing these files. Please write it yourself using the guide from https://github.com/Stypox/dicio-sentences-compiler
| override fun getSpeechOutput(ctx: SkillContext): String = if (name == null) { | ||
| ctx.getString(R.string.skill_sms_not_sending) | ||
| } else { | ||
| "" // do not speak anything since the message was sent |
Owner
There was a problem hiding this comment.
Saying something while a call is starting is bad, but saying something while a message is being sent is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SMS skill, based on the telephone skill.
The sentences are setup so you can add your message into the first query ("Send a message to Tyler that says Can you grab cat food at the store") or in two-steps ("Send a message to Tyler" -> "What do you want the message to say?" -> "Can you grab cat food at the store?")
Resolves #270