Fix AirCube ZHA quirk import on current zigpy#12
Open
georgemclaughlin wants to merge 1 commit intoStuckAtPrototype:masterfrom
Open
Fix AirCube ZHA quirk import on current zigpy#12georgemclaughlin wants to merge 1 commit intoStuckAtPrototype:masterfrom
georgemclaughlin wants to merge 1 commit intoStuckAtPrototype:masterfrom
Conversation
Owner
|
oh no, I pushed this on error. Thanks! That said, the values need to become eCO2 not CO2 so it is not misleading. |
nicholas1513
reviewed
Apr 9, 2026
nicholas1513
left a comment
There was a problem hiding this comment.
@StuckAtPrototype like this? to match the fallback name on line 33/34 ?
| AirQualityCluster.cluster_id, | ||
| endpoint_id=10, | ||
| unit="ppm", | ||
| device_class=SensorDeviceClass.CO2, |
There was a problem hiding this comment.
Suggested change
| device_class=SensorDeviceClass.CO2, | |
| device_class=SensorDeviceClass.eCO2, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the AirCube ZHA quirk for newer zigpy/Home Assistant versions by adding a missing
device_classto the eCO2 sensor metadata.Problem
On current Home Assistant / zigpy, the custom quirk can fail to import with:
This prevents the custom AirCube entities from loading in ZHA.
Change
Add
device_class=SensorDeviceClass.CO2to theeco2sensor definition inzha/aircube.py.Verification
Verified against Home Assistant logs:
zigpy.quirks.v2.CustomDeviceV2