This repository was archived by the owner on Feb 1, 2018. It is now read-only.
data.iteritems given a dictionary to iterate#3
Open
MarkMarine wants to merge 3 commits intoStackdriver:masterfrom
Open
data.iteritems given a dictionary to iterate#3MarkMarine wants to merge 3 commits intoStackdriver:masterfrom
MarkMarine wants to merge 3 commits intoStackdriver:masterfrom
Conversation
added 2 commits
December 18, 2014 11:42
data is a list object, and when merging in it was called with .iteritems() but list objects don't have .iteritems() and this fails when called. data[0] is the first dictionary returned from the stackdriver response. This corrects the bug.
When merging keys in, we have a list. When GET runs it's using a dictionary already, so we don't need [0]
Author
|
I fixed the CREATE but broke GET. This is corrected by ac4f02a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data is a list object, and when merging in it was called with
.iteritems() but list objects don't have .iteritems() and this
fails when called. data[0] is the first dictionary returned from
the stackdriver response. This corrects the bug.