Conversation
Adds five new MCP tools that call the new private public API endpoints exposed on the Django side (api/v1/public/legal_intake/): list_legal_intakes – GET /v1/public/legal_intake/ (read) get_legal_intake – GET /v1/public/legal_intake/<id>/ (read) create_legal_intake – POST /v1/public/legal_intake/ (write) update_legal_intake – PATCH /v1/public/legal_intake/<id>/ (write) delete_legal_intake – DELETE /v1/public/legal_intake/<id>/ (write) Read tools are registered without the write flag so they are available in read-only mode. Write tools require write mode to be enabled. SpotDraftClient gains two new methods (patch, delete) following the exact same error-handling pattern as the existing post method. Testing notes ------------- * TypeScript type-checked locally (tsc --noEmit) – zero errors. * Tools follow the same pattern as the existing counter-parties tools.
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
|
|
||
| const endpoint = `/v1/public/legal_intake/${request.legal_intake_id}/`; | ||
| logger.debug('SpotDraft MCP', `Making DELETE request to ${endpoint}`); | ||
| await spotdraftClient.delete(endpoint); | ||
| return { success: true, message: `Legal intake ${request.legal_intake_id} deleted successfully.` }; |
There was a problem hiding this comment.
delete_legal_intake is documented to return null/204 but the handler returns { success: true, message: ... }, should we return null (204) or update the contract/schema to match?
Finding type: Breaking Changes | Severity: 🔴 High
Want Baz to fix this for you? Activate Fixer
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
src/tools/legal-intake/delete_legal_intake.ts around lines 35 to 41, the
deleteLegalIntake handler currently returns an object ({ success: true, message: ... })
but the tool's description documents that it returns null (204 No Content). Change the
function signature to return Promise<null> and replace the final return statement with
return null; (keep the spotdraftClient.delete call and logging). Ensure any exported
types or usage sites are updated if they expect the old object. This preserves the
documented MCP contract.
| async patch(endpoint: string, body?: any) { | ||
| const url = `${this.baseUrl}${endpoint}`; | ||
|
|
||
| this.logger.debug('SpotDraftClient', `PATCH ${url}`); | ||
|
|
There was a problem hiding this comment.
SpotDraftClient.patch duplicates get/post fetch/log/error-handling — should we extract a private request(method, endpoint, options) helper that get/post/patch/delete call?
Finding type: Code Dedup and Conventions | Severity: 🟢 Low
Want Baz to fix this for you? Activate Fixer
| async delete(endpoint: string) { | ||
| const url = `${this.baseUrl}${endpoint}`; | ||
|
|
||
| this.logger.debug('SpotDraftClient', `DELETE ${url}`); | ||
|
|
There was a problem hiding this comment.
SpotDraftClient.delete duplicates the get/post fetch/error-handling boilerplate — should we centralize all HTTP verbs into a private async request(method, endpoint, options) that handles fetch, JSON parsing, and APIError handling?
Finding type: Code Dedup and Conventions | Severity: 🟢 Low
Want Baz to fix this for you? Activate Fixer
| const updateLegalIntake = async (request: UpdateLegalIntakeRequest, spotdraftClient: SpotDraftClient): Promise<any> => { | ||
| if (!request.legal_intake_id) throw new Error('legal_intake_id is required.'); | ||
|
|
||
| const { legal_intake_id, ...body } = request; | ||
| const endpoint = `/v1/public/legal_intake/${legal_intake_id}/`; | ||
| logger.debug('SpotDraft MCP', `Making PATCH request to ${endpoint}`); | ||
| return spotdraftClient.patch(endpoint, body); |
There was a problem hiding this comment.
updateLegalIntake sends an empty PATCH when only legal_intake_id is provided despite the docstring 'At least one updatable field must be supplied' — should we enforce Object.keys(body).length > 0 and throw before calling spotdraftClient.patch?
Finding type: Logical Bugs | Severity: 🔴 High
Want Baz to fix this for you? Activate Fixer
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
src/tools/legal-intake/update_legal_intake.ts around lines 101-107, the
updateLegalIntake function only validates legal_intake_id and then PATCHes with body
which can be an empty object. Enforce that at least one updatable field is provided by
checking Object.keys(body).length > 0 after destructuring; if it's zero, throw an Error
with a descriptive message like 'At least one updatable field must be supplied.'
Otherwise proceed to build the endpoint, log, and call spotdraftClient.patch as before.
Make this change within the updateLegalIntake function so the runtime behavior matches
the tool docstring.
2 participants
User description
Summary
Adds five MCP tools that expose the new private public API endpoints for legal intakes (see companion PR in
django-rest-api). Also extendsSpotDraftClientwithpatchanddeletemethods needed to call the update and delete endpoints.New tools
list_legal_intakesGET/v1/public/legal_intake/get_legal_intakeGET/v1/public/legal_intake/<id>/create_legal_intakePOST/v1/public/legal_intake/update_legal_intakePATCH/v1/public/legal_intake/<id>/delete_legal_intakeDELETE/v1/public/legal_intake/<id>/Read tools are available in read-only mode. Write tools are gated behind the
writeflag (consistent with all existing write tools).SpotDraftClient changes
Added
patch(endpoint, body)anddelete(endpoint)methods following the exact same structure (fetch, error handling, logging) as the existingpostmethod.Files changed
src/spotdraft_client.tspatchanddeletemethodssrc/tools/legal-intake/list_legal_intakes.tssrc/tools/legal-intake/get_legal_intake.tssrc/tools/legal-intake/create_legal_intake.tssrc/tools/legal-intake/update_legal_intake.tssrc/tools/legal-intake/delete_legal_intake.tssrc/tools/index.tsTesting notes
tsc --noEmit) — zero errors.Generated description
Below is a concise technical summary of the changes proposed in this PR:
Expose legal intake CRUD through new MCP tools wired into the global registry so agents can hit the
/v1/public/legal_intake/endpoints. ExtendSpotDraftClientwithpatchanddeletemethods to support the new update and delete operations via the MCP layer.Modified files (6)
Latest Contributors(2)
patchanddeletesupport toSpotDraftClientso MCP handlers can send the new update and delete requests with the existing error/logging patterns.Modified files (1)
Latest Contributors(2)