Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71b721d863
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private fun updatePluginVersion(file: File, id: String, version: String) { | ||
| val content = file.readText() | ||
| // Regex to match: id("plugin-id") version "version-number" | ||
| val regex = """id\("$id"\)\s+version\s+"([^"]+)"""".toRegex() |
There was a problem hiding this comment.
The regex in updatePluginVersion() interpolates pluginId directly, so metacharacters in valid plugin IDs (notably .) are treated as regex wildcards. This can rewrite unrelated plugin declarations that merely match the wildcard pattern (for example, id("ioXspineXvalidation") when updating io.spine.validation), causing incorrect version bumps across build.gradle.kts files. Build the pattern with Regex.escape(id) before interpolation so plugin IDs are matched literally.
Useful? React with 👍 / 👎.
2 participants
This PR applies latest
configbringing latestbuildSrcchanges to this repository.