Rebase onto current rust-lang/rust master#1
Closed
futile wants to merge 7126 commits intoSparrowLii:expand1from
Closed
Rebase onto current rust-lang/rust master#1futile wants to merge 7126 commits intoSparrowLii:expand1from
futile wants to merge 7126 commits intoSparrowLii:expand1from
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I went ahead and did a rebase against rust's current master.
x test tidyandx checkboth pass.Since the first two commits are no longer compatible with master (some new types that don't have
Hash), but the last commit removesHashagain anyway, I marked those two commits as "does not compile". But the final state (with all three commits) compiles again (and passestidy&check).There are two new failures when running
x test tests/ui, but also more tests in total, so that makes sense.Failures from the PR CI: https://github.com/rust-lang/rust/actions/runs/9232104911/job/25402877228?pr=125356
Failures with this rebase:
Is this helpful? Can you see something obvious I missed? Thanks! :)