session_timeout: make sure remember_me's before_logout hook gets called#358
Open
jankoegel wants to merge 3 commits intoSorcery:mainfrom
Open
session_timeout: make sure remember_me's before_logout hook gets called#358jankoegel wants to merge 3 commits intoSorcery:mainfrom
jankoegel wants to merge 3 commits intoSorcery:mainfrom
Conversation
hook gets called on logout + only logout calls before & after logout hooks: https://github.com/Sorcery/sorcery/blob/d9dc0bd80a3d5689398baea4489b14ed78e6c42d/lib/sorcery/controller.rb#L75-L78 + remember_me uses a before_logout hook to clear its cookie: https://github.com/Sorcery/sorcery/blob/d9dc0bd80a3d5689398baea4489b14ed78e6c42d/lib/sorcery/controller/submodules/remember_me.rb#L22
|
@jankoegel i am trying to get the test from my PR to yours, but the test are broken because rspec version with rails 7.1: I have upgrade the rspec, but a lot of other test become broken due the upgrade rspec-rails from version 3 to version 6. I will open a PR from my test branch to yours and after that we check with @joshbuker its OK to merge everything together |
joshbuker
requested changes
Mar 8, 2024
Member
joshbuker
left a comment
There was a problem hiding this comment.
Interesting...This looks like it should work, but appears to be failing the OAuth session timeout specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
session_timeoutas well as theremember_mesubmodule the following can happen:invalidate_sessions_beforetimestamp is set tonow, their remember_me sessions will not be invalidatedsession_timeoutsubmodule'svalidate_sessionIn the code
only
logoutcalls before & after logout hooks:sorcery/lib/sorcery/controller.rb
Lines 75 to 78 in d9dc0bd
remember_meuses abefore_logouthook to clear its cookie:sorcery/lib/sorcery/controller/submodules/remember_me.rb
Line 22 in d9dc0bd