PLUGINAPI-182 Rework the new manifest module#280
Merged
Conversation
Member
henryju
commented
Feb 27, 2026
henryju
commented
- the JAR was not published
- the Version class was duplicated
hashicorp-vault-sonar-prod
bot
changed the title
henryju
force-pushed
the
jh/fix_manifest_publication
branch
2 times, most recently
from
8f7ce77 to
32a4979
Compare
Contributor
antoine-vinot-sonarsource
left a comment
antoine-vinot-sonarsource
left a comment
There was a problem hiding this comment.
LGTM, I only have one minor feedback and one question.
antoine-vinot-sonarsource
approved these changes
Mar 11, 2026
henryju
force-pushed
the
jh/fix_manifest_publication
branch
from
32a4979 to
f1225b1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.