feat(config): migrate to runtime config.json loading#2
Merged
Conversation
- Replace build-time environment variables with runtime config.json - Add FileConfigRepository with Zod validation (AppConfig schema) - Create singleton configRepositoryInstance for dependency injection - Update axiosInstance to fetch baseURL from config via interceptor - Update chatApi to use configRepository for streaming URL - Add useConfig hook with React Query caching (staleTime: Infinity) - Follow hexagonal architecture pattern from pickpro-front Domain: - src/domain/entities/config/appConfig.ts - Zod-validated config schema - src/domain/ports/config/configRepository.ts - Repository interface Infrastructure: - src/infrastructure/config/fileConfigRepository.ts - Config fetcher with caching - src/infrastructure/config/configRepositoryInstance.ts - Singleton instance Application: - src/application/hooks/config/useConfig.ts - React Query hook Tests: - tests/unit/infrastructure/config/fileConfigRepository.test.ts - tests/unit/hooks/config/useConfig.test.tsx - Updated axiosInstance.test.ts for new mock pattern Infrastructure changes (flux/dev): - Update ConfigMap to JSON format with apiBaseUrl/wsBaseUrl - Mount config.json via volume in deployment BREAKING CHANGE: Removed VITE_API_BASE_URL and VITE_WS_BASE_URL environment variables. Use public/config.json instead.
- Add role="none" to inner <dialog> elements to prevent double role="dialog" - Fixes SonarQube accessibility issues about nested dialog roles - Tests passing (158 tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates composable-ui from build-time environment variables to runtime
config.jsonloading, following the same pattern as pickpro-front.Changes
Domain Layer
src/domain/entities/config/appConfig.ts): Zod-validated config schema withapiBaseUrlandwsBaseUrlsrc/domain/ports/config/configRepository.ts): Repository interface for config loadingInfrastructure Layer
src/infrastructure/config/fileConfigRepository.ts): Fetches/config.jsonwith caching and error handlingsrc/infrastructure/config/configRepositoryInstance.ts): Singleton instance for dependency injectionApplication Layer
src/application/hooks/config/useConfig.ts): React Query hook withstaleTime: InfinityInfrastructure (flux/dev)
config.jsoncontainingapiBaseUrlandwsBaseUrl/usr/share/nginx/html/config.jsonTest Plan
Breaking Change
Removed
VITE_API_BASE_URLandVITE_WS_BASE_URLenvironment variables. Usepublic/config.jsoninstead.Related