Skip to content

fix: Post-review cleanup#6

Merged
Kaiohz merged 1 commit intomainfrom
fix/post-review-cleanup
Apr 5, 2026
Merged

fix: Post-review cleanup#6
Kaiohz merged 1 commit intomainfrom
fix/post-review-cleanup

Conversation

@Kaiohz
Copy link
Copy Markdown
Contributor

@Kaiohz Kaiohz commented Apr 5, 2026

Summary

5 post-review cleanup fixes

  • Add case _: to match statement in SendMessageUseCase (prevents UnboundLocalError)
  • Remove non-existent model_kwargs field from README
  • Clean up MCP close() — remove dead loop, add defensive guard
  • Remove unused AsyncSession import from dependencies.py
  • Replace placeholder pyproject.toml description

Test plan

  • 236 unit tests passing
  • SonarQube: 0 issues, Trivy: 0 vulnerabilities
  • QA: 6/6 scenarios pass on Docker stack

… MCP close, unused import, project description

- Add case _: raise ValueError to match statement in SendMessageUseCase (prevents UnboundLocalError)
- Remove non-existent model_kwargs field from README documentation
- Clean up MCP close() — remove dead loop, add defensive guard for future library versions
- Remove unused AsyncSession import from dependencies.py
- Replace placeholder pyproject.toml description with actual project description
@Kaiohz Kaiohz marked this pull request as ready for review April 5, 2026 18:08
@Kaiohz Kaiohz merged commit d6e377d into main Apr 5, 2026
1 check passed
@Kaiohz Kaiohz deleted the fix/post-review-cleanup branch April 5, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant