Partially add zwp-input-method-v2#490
Merged
PolyMeilex merged 1 commit intoSmithay:masterfrom May 13, 2025
Merged
Conversation
PolyMeilex
reviewed
May 13, 2025
Member
PolyMeilex
left a comment
There was a problem hiding this comment.
I'm no IME expert, but this looks good to me so far.
Author
|
Thanks a lot for the review! While working on supporting the next input-method, I noticed that I missed the |
Only the input-method object is supported. No keyboard grab, no popup surface. Co-authored-by: Bartłomiej Maryńczak <marynczak.bartlomiej@gmail.com>
PolyMeilex
approved these changes
May 13, 2025
Member
|
Thanks for working on this, excited to see where the whole IME Wayland story will go |
Member
btw, it's not strictly required, as Connection is Clone. So one could just store it in the state. |
Author
|
I still use the Connection in the app state, but I added it for consistency... and for when someone decides to use 2 connections I guess :P |
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the input-method object is supported. No keyboard grab, no popup surface.
This is already useful.
Client demo: https://codeberg.org/dcz/stiwri
The client only does a couple canned requests, but it shows:
which is most of the functionality here.