Skip to content

Partially add zwp-input-method-v2#490

Merged
PolyMeilex merged 1 commit intoSmithay:masterfrom
dcz-self:inputmethodv2
May 13, 2025
Merged

Partially add zwp-input-method-v2#490
PolyMeilex merged 1 commit intoSmithay:masterfrom
dcz-self:inputmethodv2

Conversation

@dcz-self
Copy link
Copy Markdown

Only the input-method object is supported. No keyboard grab, no popup surface.

This is already useful.

Client demo: https://codeberg.org/dcz/stiwri

The client only does a couple canned requests, but it shows:

  • looking at preedit (command line)
  • submitting text (button)
  • showing preedit (buttons)

which is most of the functionality here.

Copy link
Copy Markdown
Member

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no IME expert, but this looks good to me so far.

@dcz-self
Copy link
Copy Markdown
Author

Thanks a lot for the review!

While working on supporting the next input-method, I noticed that I missed the connection: &Connection param in Handler. It's added now.

Only the input-method object is supported. No keyboard grab, no popup surface.

Co-authored-by: Bartłomiej Maryńczak <marynczak.bartlomiej@gmail.com>
@PolyMeilex PolyMeilex merged commit dee5011 into Smithay:master May 13, 2025
6 of 7 checks passed
@PolyMeilex
Copy link
Copy Markdown
Member

Thanks for working on this, excited to see where the whole IME Wayland story will go

@PolyMeilex
Copy link
Copy Markdown
Member

I noticed that I missed the connection: &Connection param in Handler

btw, it's not strictly required, as Connection is Clone. So one could just store it in the state.

@dcz-self
Copy link
Copy Markdown
Author

I still use the Connection in the app state, but I added it for consistency... and for when someone decides to use 2 connections I guess :P

@dcz-self
Copy link
Copy Markdown
Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants