Open
Conversation
loucass003
requested changes
Feb 27, 2026
server/core/src/main/java/dev/slimevr/protocol/rpc/installinfo/RPCInstallInfoHandler.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallerUtils.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/Updater.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/platform/ProtobufBridge.kt
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/platform/ProtobufMessages.java
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/platform/SteamVRBridge.kt
Show resolved
Hide resolved
…on to get path to exe dir inside react. Moved the Error collecting consent modal to a page.
81bc9d6 to
35955f7
Compare
Added specific Nix and SteamOS configs. Updated Feeder install function on Linux. Update Feeder install function on Windows. Lint.
Remove wrong return string from executeShellCommand in RPCInstallInfoHandler.kt
Skip Installation of drivers if user is not using the steam version.
loucass003
requested changes
Mar 3, 2026
gui/src/components/onboarding/pages/ErrorCollectingConstent.tsx
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/rpc/installinfo/RPCInstallInfoHandler.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallerUtils.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/Linux.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/Windows.kt
Outdated
Show resolved
Hide resolved
Added system env variable to disable installer
ImSapphire
requested changes
Mar 3, 2026
server/core/src/main/java/dev/slimevr/protocol/rpc/installinfo/RPCInstallInfoHandler.kt
Outdated
Show resolved
Hide resolved
Fixed mistake with disabling installer. Update Windows usb driver install to read log from pnputil.
ImSapphire
requested changes
Mar 4, 2026
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/Linux.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Sapphire <imsapphire0@gmail.com>
ImSapphire
reviewed
Mar 5, 2026
gui/src/components/onboarding/pages/ErrorCollectingConstent.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/ErrorCollectingConstent.tsx
Outdated
Show resolved
Hide resolved
Updated the logic to detect if udev rules are installed skip the check when running on SteamOS or NixOS. Remove the unused ErrorConsentModal. PR Feedback
ImSapphire
reviewed
Mar 5, 2026
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/rpc/installinfo/RPCInstallInfoHandler.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/rpc/installinfo/RPCInstallInfoHandler.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Sapphire <imsapphire0@gmail.com>
loucass003
reviewed
Mar 5, 2026
| } | ||
|
|
||
| fun steamVRDriver() { | ||
| val steamVRLocation = executeShellCommand("powershell.exe", "-Command", "(Get-ItemProperty \'HKLM:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Steam App 250820\').InstallLocation")?.trim() |
Member
There was a problem hiding this comment.
we already have tooling to read from registry in the server. maybe we should use that?
loucass003
reviewed
Mar 5, 2026
| LogManager.warning("Couldn't determine OS distribution: $e") | ||
| return | ||
| } | ||
| if (linuxFlavour.contains("ID=steamos") || linuxFlavour.contains("ID=nixos") || linuxFlavour.contains("ID_LIKE=nixos")) { |
Member
There was a problem hiding this comment.
i dont like the idea of checking for os like that. makes expension annoying imo
and it is duplicated in two locations in the code.
Author
There was a problem hiding this comment.
I'm thinking of making it so the InstalledInfoRequest packet has a table of requests it can do and have the gui specifically ask for udev rules when on Linux.
Author
There was a problem hiding this comment.
That kinda feels like moving the problem to a differerent spot instead of solving it though.
loucass003
reviewed
Mar 5, 2026
|
|
||
| class Windows { | ||
|
|
||
| val path: String? = System.getProperty("user.dir") |
Member
There was a problem hiding this comment.
why is it nullable if it is set here?
loucass003
reviewed
Mar 5, 2026
|
|
||
| class Linux { | ||
|
|
||
| val path: String? = System.getProperty("user.dir") |
ImSapphire
reviewed
Mar 5, 2026
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/InstallDrivers.kt
Outdated
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/Linux.kt
Show resolved
Hide resolved
server/desktop/src/main/java/dev/slimevr/desktop/install/drivers/Windows.kt
Show resolved
Hide resolved
Moved installer registry checks to RegEdit.kt
Moved installer registry checks to RegEdit.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr contains changes needed for the steam release to run.
Changes include:
This PR relies on this PR from solarXR SlimeVR/SolarXR-Protocol#198