Skip to content

Player List API (Interface with the tab list)#32

Open
Ascynx wants to merge 5 commits intoSkyBlock-Central:mainfrom
Ascynx:playerlist-api
Open

Player List API (Interface with the tab list)#32
Ascynx wants to merge 5 commits intoSkyBlock-Central:mainfrom
Ascynx:playerlist-api

Conversation

@Ascynx
Copy link
Member

@Ascynx Ascynx commented Jun 30, 2023 •
edited
Loading

Currently planned:

  • Access to tab list data, main list, header, footer.
  • Access to footer data per category e.g: Active Effects, Cookie Buff, Upgrades.
  • Access to tab list data depending on the category e.g: Players, Server Info, Account Info.

@Ascynx Ascynx added the enhancement New feature or request label Jun 30, 2023
Ascynx added 2 commits June 30, 2023 23:53
@Ascynx
Categorized player list data
c5fc293 
Works fine for Header and footer but still a few hiccups to deal with with the main tab list.
@Ascynx
Categorized tab data.
eb3143f 
Fixed tab categories being overriden if they appeared twice.

Also refactored getTabCategories -> getPlayerListCategories.
@Ascynx Ascynx marked this pull request as ready for review July 2, 2023 10:37
@Zickles
Copy link
Contributor

Zickles commented Jul 30, 2023

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ascynx @Zickles