Open
Conversation
Fixes a bug where patterns with two expressions separated only by
whitespace or optional elements would fail to parse.
The issue was in ExpressionElement.java at line 135-137, where the
code incorrectly skipped processing when the next expression was the
last element in the pattern. This caused patterns like:
- "claude test %number% [of] %number%"
- "location %direction% [of] %location%"
To fail when parsing inputs like:
- "claude test 1 2"
- "location above {_loc}"
The fix removes the incorrect boundary check. When an expression is
the last element, getPossibleInputs() correctly returns the end-of-line
marker "\0", which is properly handled by the existing code.
Includes unit test (ClaudeDebugTest) that verifies both space-separated
and optional text cases work correctly.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fix/expression space parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future stuff