Skip to content

Stop using SSH to rotate secrets in Azure VMs and fix 1Password/GCP issues#42

Open
gdioguardi wants to merge 4 commits intomasterfrom
feb-2026-fix
Open

Stop using SSH to rotate secrets in Azure VMs and fix 1Password/GCP issues#42
gdioguardi wants to merge 4 commits intomasterfrom
feb-2026-fix

Conversation

@gdioguardi
Copy link
Contributor

@gdioguardi gdioguardi commented Mar 10, 2026 •
edited
Loading

This does the following:

  • Cycle out Azure VMs to rotate secrets instead of using SSH
  • Update 1Password functions due to new SDK version
  • Set maxSurge for GCP instance group rotations to 3
  • Fix validation to work with the 'rotate_ses_smtp_user' action

@gdioguardi gdioguardi self-assigned this Mar 10, 2026
miketypeguy
miketypeguy approved these changes Mar 10, 2026
View reviewed changes
Copy link
Member

@miketypeguy miketypeguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haggaret haggaret haggaret approved these changes

@miketypeguy miketypeguy miketypeguy approved these changes

@ryan-j-mci ryan-j-mci ryan-j-mci approved these changes

@sigJoe sigJoe Awaiting requested review from sigJoe

Assignees

@gdioguardi gdioguardi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gdioguardi @haggaret @miketypeguy @ryan-j-mci