Migrate workspace symbol to use Rubydex#4019
Open
vinistock wants to merge 1 commit into03-03-migrate_go_to_definition_to_use_rubydexfrom
Open
Migrate workspace symbol to use Rubydex#4019vinistock wants to merge 1 commit into03-03-migrate_go_to_definition_to_use_rubydexfrom
vinistock wants to merge 1 commit into03-03-migrate_go_to_definition_to_use_rubydexfrom
Conversation
vinistock
added
server
20 tasks
vinistock
force-pushed
the
03-19-migrate_workspace_symbol_to_rubydex
branch
from
b182366 to
23fc40e
Compare
vinistock
force-pushed
the
03-03-migrate_go_to_definition_to_use_rubydex
branch
from
005200d to
f3b0fcc
Compare
st0012
approved these changes
Mar 20, 2026
| @global_state = global_state | ||
| @query = query | ||
| @index = global_state.index #: RubyIndexer::Index | ||
| @graph = global_state.graph #: Rubydex::Graph |
Member
There was a problem hiding this comment.
Since we don't need @global_state anymore, does it make sense to just pass graph in?
| declaration.definitions.each do |definition| | ||
| location = definition.location | ||
| uri = URI(location.uri) | ||
| file_path = uri.full_path |
Member
There was a problem hiding this comment.
Not blocking, but does it make sense to make this Definition#full_path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR migrates workspace symbol to use Rubydex.
Implementation
Graph#searchto match symbolsvisibilityas a new field in workspace symbols. I think excluding based on visibility was not the right choice, so I removed that filterto_lsp_kindto our definition patchesAutomated Tests
I removed a redundant test and expanded the one about private/protected definitions.