Conversation
This was referenced Mar 9, 2026
Contributor
Author
kdaviduik
changed the base branch from
kd-update-to-typescript
to
graphite-base/943
kdaviduik
force-pushed
the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
from
731bb4a to
cdb7712
Compare
kdaviduik
changed the base branch from
graphite-base/943
to
03-09-fix_run_ci_on_all_pull_requests_not_just_those_targeting_main
kdaviduik
force-pushed
the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
from
cdb7712 to
d65c289
Compare
This was referenced Mar 9, 2026
Testem's launch_in_ci required both Chrome and Firefox, but Firefox
is not installed locally, which caused `testem ci` to abort before
running any tests. Remove Firefox — Chrome-only is sufficient for
local test validation. The entire test runner (Mocha + Testem) is
being replaced by Vitest + happy-dom in a future PR.
Add headless Chrome args for CI mode (--headless, --no-sandbox,
--disable-gpu) so Chrome can run on headless CI runners without
an X server. These flags only apply in CI mode — dev mode still
opens a visible browser window.
Also fix 6 pre-existing test failures in test/unit/view.js where
tests tried to reassign the read-only ES module import `Iframe`
to spy on the constructor. Replace with assertions on the
observable outcome (view.iframe.el.getAttribute('title')), which
is both correct under modern strict mode and a stronger test
pattern — verifying behavior rather than implementation details.
kdaviduik
force-pushed
the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
from
d65c289 to
a79416c
Compare
kdaviduik
force-pushed
the
03-09-fix_run_ci_on_all_pull_requests_not_just_those_targeting_main
branch
from
bba962b to
8588844
Compare
fredericoo
approved these changes
Mar 11, 2026
andguy95
approved these changes
Mar 11, 2026
Base automatically changed from
03-09-fix_run_ci_on_all_pull_requests_not_just_those_targeting_main
to
main
March 11, 2026 15:48
kdaviduik
deleted the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testem's launch_in_ci required both Chrome and Firefox, but Firefox
is not installed locally, which caused
testem cito abort beforerunning any tests. Remove Firefox — Chrome-only is sufficient for
local test validation. The entire test runner (Mocha + Testem) is
being replaced by Vitest + happy-dom in a future PR.
Also fix 6 pre-existing test failures in test/unit/view.js where
tests tried to reassign the read-only ES module import
Iframeto spy on the constructor. Replace with assertions on the
observable outcome (view.iframe.el.getAttribute('title')), which
is both correct under modern strict mode and a stronger test
pattern — verifying behavior rather than implementation details.