refactor(macro): rename memento_derive_off to skip_memento_default_derives#43
Merged
ShapelessCat merged 1 commit intomainfrom Mar 27, 2026
Conversation
…rives The previous attribute name `memento_derive_off` was misleading because it did not turn off the `Deserialize` derive when the `serde` feature was enabled. The new name `skip_memento_default_derives` correctly communicates that it only suppresses the macro's default derivations (`Clone`, `Debug`, `PartialEq`) for the generated memento struct. This aligns the terminology with the existing `#[recallable(skip)]` attribute. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ShapelessCat
deleted the
rename-memento_derive_off-as-skip_memento_default_derives
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attribute name
memento_derive_offwas misleading because it did not turn off theDeserializederive when theserdefeature was enabled. The new nameskip_memento_default_derivescorrectly communicates that it only suppresses the macro's default derivations (Clone,Debug,PartialEq) for the generated memento struct.This aligns the terminology with the existing
#[recallable(skip)]attribute.