Rewrite du TranslationManager + Impl adminshop, commands, api#1161
Open
iambibi wants to merge 23 commits intoServerOpenMC:v2.5from
Open
Rewrite du TranslationManager + Impl adminshop, commands, api#1161iambibi wants to merge 23 commits intoServerOpenMC:v2.5from
iambibi wants to merge 23 commits intoServerOpenMC:v2.5from
Conversation
…rOpenMC#1158) * fix: claim dupli * fix: Cannot invoke "String.isEmpty()" because "content" is null * fix: FancyNpcsPlugin is null
Member
Author
|
apres plusieures batailles avec les components et les lois de la translation des messages, je pense avoir trouvé une bonne solution afin de combiner la lisibilité et le pratique |
Member
Author
|
je suis deja a 164 fichiers changé, m'en voulez pas, je viens a peine de finir une feature mdrr. PS: y'a des endroits ou j'ai faillit mourrir sur le code de l'admin shop |
Member
Author
|
prochaine feature : Les Villes 🤯 💥 |
Member
Author
|
vous voulez que je fasse une PR pour l'implémentation du systeme de translation + traduction adminshop et api, et commandes et une PR par feature traduite? (si premiere choisie, alors faudra vite la passer, je peux finir la world gen de la dimension des reves mais ça durera pas 10 ans) |
iambibi
changed the title
Member
Author
|
a review, assez rapidement (~1-2 semaines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
Rewrite de la base des translations, tout les messages seront dans un fichier (ressources/translations/lang_fr_FR.properties par ex).
A partir que cette PR passe, toute nouvelle PR devra mettre ses messages dans le fichier lang
Choses non traduites :
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements