Fix TC LST warning

[bdanzi]

This PR addresses the spurious warning triggered during Track Candidate (TC) allocation in events with a small number of TCs. Currently, the warning is thrown whenever the dynamic memory allocation for TCs is exactly equal to the required number, which can happen especially in no-pileup events. This update refines the check so that the warning is issued only when the allocation exceeds the static maximum number of TCs (nMaxTC).

FYI @GNiendorf @slava77

[slava77]

run-ci: all

[slava77]

I started the CI, but it looks simple enough that it can go upstream

[github-actions]

The PR was built and ran successfully in standalone mode running on CPU. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     29.4    319.2    236.8    141.5     51.7    682.0     10.7    131.6    113.2    216.8      0.1    1933.0    1221.6+/- 295.4     604.2   explicit[s=4] (target branch)
   avg     29.4    318.2    237.0    141.5     52.7    685.0     10.7    131.9    112.8    218.6      0.1    1937.9    1223.5+/- 300.3     607.0   explicit[s=4] (this PR)

[github-actions]

The PR was built and ran successfully with CMSSW running on CPU. Here are some plots.

OOTB All Tracks

The full set of validation and comparison plots can be found here.