Skip to content

Adding pass-through option to MultiTrackSelector (for LST tracking / seeding) - LST-internal only#247

Open
mmasciov wants to merge 2 commits intomasterfrom
passThroughMTS-SL
Open

Adding pass-through option to MultiTrackSelector (for LST tracking / seeding) - LST-internal only#247
mmasciov wants to merge 2 commits intomasterfrom
passThroughMTS-SL

Conversation

@mmasciov
Copy link
Copy Markdown

@mmasciov mmasciov commented Mar 19, 2026

As per title.

FYI: @bucket420, @slava77, @bdanzi

@mmasciov
Copy link
Copy Markdown
Author

mmasciov commented Mar 19, 2026

run-ci: all

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

The PR was built and ran successfully in standalone mode running on CPU. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     35.8    401.3    277.8    196.4     68.9    837.9     14.0    148.2    127.2    258.7      0.1    2366.3    1492.6+/- 704.8     761.2   explicit[s=4] (target branch)
   avg     31.1    371.0    259.7    154.2     59.7    776.0     11.9    137.1    133.3    268.3      0.1    2202.4    1395.2+/- 467.3     742.0   explicit[s=4] (this PR)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

There was a problem while building and running with CMSSW. The logs can be found here.

@mmasciov mmasciov force-pushed the passThroughMTS-SL branch from 4ae573e to 2f5c077 Compare March 19, 2026 13:54
@mmasciov
Copy link
Copy Markdown
Author

mmasciov commented Mar 19, 2026

run-ci: all

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

The PR was built and ran successfully in standalone mode running on CPU. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     28.2    324.0    243.2    137.1     47.4    699.6     10.9    116.0    118.5    209.2      0.8    1934.9    1207.1+/- 289.8     599.5   explicit[s=4] (target branch)
   avg     28.2    324.3    242.6    136.4     47.7    699.6     10.9    115.5    120.0    208.9      0.1    1934.2    1206.5+/- 292.6     600.3   explicit[s=4] (this PR)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

The PR was built and ran successfully with CMSSW running on CPU. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

slava77
slava77 reviewed Mar 19, 2026
View reviewed changes
@slava77
Copy link
Copy Markdown

slava77 commented Mar 24, 2026

@mmasciov
there are conflicts here now in RecoTracker/IterativeTracking/python/HighPtTripletStep_cff.py (changes in this file were merged on May 19)

slava77
slava77 reviewed Mar 24, 2026
View reviewed changes
FastSimulation/Tracking/plugins/FastTrackerRecHitMaskFromSeedProducer.cc Outdated
FastTrackerRecHitMaskFromSeedProducer::FastTrackerRecHitMaskFromSeedProducer(const edm::ParameterSet& iConfig)
: trajectories_(consumes<TrajectorySeedCollection>(iConfig.getParameter<edm::InputTag>("trajectories"))),
recHits_(consumes<FastTrackerRecHitCollection>(iConfig.getParameter<edm::InputTag>("recHits"))) {
produces<std::vector<bool> >();
Copy link
Copy Markdown

@slava77 slava77 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to start put tokens

Copy link
Copy Markdown

@slava77 slava77 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is marked as resolved but there is not change (implies edm::EDPutToken)

Copy link
Copy Markdown
Author

@mmasciov mmasciov Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mmasciov mmasciov force-pushed the passThroughMTS-SL branch from b6df51b to 78e2e86 Compare March 24, 2026 18:25
@mmasciov mmasciov force-pushed the passThroughMTS-SL branch from 78e2e86 to e79c4f1 Compare March 25, 2026 13:44
@slava77
Copy link
Copy Markdown

slava77 commented Mar 25, 2026

run-ci: cmssw

slava77
slava77 reviewed Mar 25, 2026
View reviewed changes
FastSimulation/Tracking/plugins/FastTrackerRecHitMaskFromSeedProducer.cc Outdated
FastTrackerRecHitMaskFromSeedProducer::FastTrackerRecHitMaskFromSeedProducer(const edm::ParameterSet& iConfig)
: trajectories_(consumes<TrajectorySeedCollection>(iConfig.getParameter<edm::InputTag>("trajectories"))),
recHits_(consumes<FastTrackerRecHitCollection>(iConfig.getParameter<edm::InputTag>("recHits"))) {
produces<std::vector<bool> >();
Copy link
Copy Markdown

@slava77 slava77 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is marked as resolved but there is not change (implies edm::EDPutToken)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

The PR was built and ran successfully with CMSSW running on CPU. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@mmasciov mmasciov force-pushed the passThroughMTS-SL branch from e79c4f1 to f33e280 Compare March 25, 2026 18:18
@mmasciov
Copy link
Copy Markdown
Author

mmasciov commented Mar 25, 2026

run-ci: cmssw

@mmasciov mmasciov force-pushed the passThroughMTS-SL branch from f33e280 to adc0cc6 Compare March 25, 2026 18:34
@mmasciov
Copy link
Copy Markdown
Author

mmasciov commented Mar 25, 2026

run-ci: cmssw

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

The PR was built and ran successfully with CMSSW running on CPU. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slava77 slava77 slava77 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmasciov @slava77