Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR downgrades the Python version requirement from 3.14 to 3.12 and adds necessary compatibility imports. The changes include updating Python version constraints across configuration files, adding from __future__ import annotations imports for forward compatibility, fixing exception handling syntax, and updating dependency locks.
Changes:
- Python version downgraded from 3.14 to 3.12 across all configuration files
- Added
from __future__ import annotationsimports to multiple source and test files - Fixed exception handling syntax in
sessionsync/git.py - Updated dependency lockfile with Python 3.12 compatible wheels
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.python-version |
Updated Python version from 3.14 to 3.12 |
pyproject.toml |
Updated requires-python and classifier to 3.12 |
.github/workflows/ci.yml |
Updated Python version in all CI jobs to 3.12 |
.github/workflows/publish.yml |
Updated Python version in publish workflow to 3.12 |
uv.lock |
Updated lockfile with Python 3.12 requirements and wheels |
sessionsync/git.py |
Fixed exception handling syntax |
Multiple .py files |
Added from __future__ import annotations for compatibility |
Comments suppressed due to low confidence (1)
sessionsync/git.py:4
- This file uses
str | Nonesyntax (PEP 604 union types) but is missingfrom __future__ import annotationsat the top. While Python 3.12 supports this syntax natively at runtime, adding the import ensures consistency with other files in the project and maintains forward compatibility patterns.
def get_current_branch() -> str | None:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.