[proxy_cloudflare_worker_example] Reimplemented ProxyDatabaseTrait for reusability.#3036
Open
bjn7 wants to merge 1 commit intoSeaQL:masterfrom
Open
[proxy_cloudflare_worker_example] Reimplemented ProxyDatabaseTrait for reusability.#3036bjn7 wants to merge 1 commit intoSeaQL:masterfrom
ProxyDatabaseTrait for reusability.#3036bjn7 wants to merge 1 commit intoSeaQL:masterfrom
Conversation
…(uuid feature for JS), and refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rewrote the previously named
orm.rs, which is now renamed tod1bridge.rs, The code is now decoupled making it a generic, reusable component. It can now be dropped into any project and used by simply importing cleanconnect_d1function. Additionally, I updated the codebase related to newProxyDatabaseTraitimplementation.Summary of Changes:
src/d1bridge.rs: Contains the generic (not related to the type system, 'generic' as an English word)connect_d1function described above.Cargo.toml: Removed the unused crateoneshot, which was previously used as a workaround for theSendtrait (now replaced byworker::send::Future).lib.rs: Instead of connecting to the database from each endpoint, the connection is now handled centrally in fetch and supplied to route.rs, from where it is distributed to all endpoints via state.route.rs: The core endpoints remain the same, but they were modified to work with the new state and include some refactoring of clustered code.utility.rs: Clustered code unrelated to routes was moved here.wrangler.toml: Apparently, the filename is case sensitive, has been renamed fromWrangler.toml.