fix: entity generation fails with comma in parentheses (#2063)#3032
Open
xingzihai wants to merge 1 commit intoSeaQL:masterfrom
Open
fix: entity generation fails with comma in parentheses (#2063)#3032xingzihai wants to merge 1 commit intoSeaQL:masterfrom
xingzihai wants to merge 1 commit intoSeaQL:masterfrom
Conversation
When model-extra-attributes contains a comma inside parentheses, entity generation fails because clap splits by comma without respecting parentheses nesting. For example: --model-extra-attributes 'test(a, b)' gets incorrectly split into ['test(a', ' b)']. The fix: - Remove value_delimiter from CLI arguments for extra derives/attributes - Add split_by_comma_ignoring_parentheses() helper function - Process values in run_generate_command with parentheses-aware splitting This allows users to pass attributes like: --model-extra-attributes 'cfg_attr(debug_assertions, derive(Debug))' Signed-off-by: OpenClaw Agent <agent@openclaw.dev>
Member
|
Would it be possible to use syn to simplify the parsing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2063
Entity generation was failing when parentheses contained commas. This PR adds bracket-aware splitting to correctly parse such cases.