fix: use split_whitespace() instead of replace(' ') in proc macros to…#3031
Merged
tyt2y3 merged 1 commit intoSeaQL:masterfrom Apr 2, 2026
Merged
Conversation
… handle newlines in long type paths
tyt2y3
approved these changes
Apr 2, 2026
Member
|
Note to self: this might not be the best approach to detect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… handle newlines in long type paths
PR Info
DeriveActiveModelEx(and other derive macros) producingcompile_error!("unexpected token")when entity module names are long (~50+ characters).replace(' ', "")with.split_whitespace().collect()across all 11 occurrences insea-orm-macrosBug Fixes
proc_macro2::TokenStream::to_string()inserts\n(newlines) for line-wrapping when the output exceeds ~80 characters. The existing code used.replace(' ', "")to normalize the stringified type, but this only strips spaces — not newlines.When entity paths like
HasMany<super::estimate_user_checker_setting::Entity>are long enough to trigger line-wrapping, the extracted path retains an embedded\n: