Clarify documentation: three approaches, explicit terminology, STJ source generator#6
Merged
ScarletKuro merged 3 commits intomasterfrom Jan 16, 2026
Merged
Conversation
…ext.Json source generator Co-authored-by: ScarletKuro <19953225+ScarletKuro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix documentation on JsonDateTimeFormatAttribute usage
Clarify documentation: three approaches, explicit terminology, STJ source generator
Jan 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 13 13
Lines 156 156
Branches 35 35
=======================================
Hits 144 144
Misses 7 7
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ScarletKuro
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Overview section incorrectly listed
JsonDateTimeFormatAttributeandDateTimeConverterResolveras separate approaches when they must be used together. Generic terms like "source generator" and "resolver" lacked precision.JsonDateTimeFormatConverter<T>was documented as source generator-only despite supporting reflection.Changes
JsonDateTimeFormatAttribute+DateTimeConverterResolveras a single approach since the attribute is non-functional without the resolverDateTimeConverterResolver" to prosExample
Before:
After:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.