Test: Cover DateTimeConverterFactoryHelper and nullable converter WriteNullValue paths#5
Merged
ScarletKuro merged 3 commits intomasterfrom Jan 15, 2026
Conversation
…d nullable converters Co-authored-by: ScarletKuro <19953225+ScarletKuro@users.noreply.github.com>
Co-authored-by: ScarletKuro <19953225+ScarletKuro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for nullable converter coverage
Add test coverage for DateTimeConverterFactoryHelper and nullable converter WriteNullValue paths
Jan 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 83.33% 92.30% +8.97%
==========================================
Files 13 13
Lines 156 156
Branches 35 35
==========================================
+ Hits 130 144 +14
+ Misses 16 7 -9
+ Partials 10 5 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ScarletKuro
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov identified two uncovered code paths: the
NotSupportedExceptioninDateTimeConverterFactoryHelper.CreateConverterfor unsupported types, and thewriter.WriteNullValue()branch in all nullable converters.Changes
InternalsVisibleToattribute to main project csproj for test access to internal classesDateTimeConverterFactoryHelperTests.cswith 11 tests covering:NotSupportedExceptionfor unsupported types (string, int)ArgumentNullExceptionfor null type parameterNullableConverterWriteTests.cswith 12 tests directly invoking converter Write methods:ConverterTests.csby using unique date format strings per test instead of reusing identicalJsonSerializerOptionsinstancesTest Results
88 tests passing (+23 from baseline of 65)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.