Skip to content

feat(exception): expose description as a property in HttpException#108

Merged
Sorikairox merged 1 commit intoSavory:mainfrom
itizarsa:main
Apr 5, 2025
Merged

feat(exception): expose description as a property in HttpException#108
Sorikairox merged 1 commit intoSavory:mainfrom
itizarsa:main

Conversation

@itizarsa
Copy link
Copy Markdown
Contributor

@itizarsa itizarsa commented Apr 4, 2025

Description


Issue Ticket Number

Fixes #107


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run deno lint AND deno fmt AND deno task test and got no
    errors.
  • I have followed the contributing guidelines of this project as mentioned
    in CONTRIBUTING.md
  • I have checked to ensure there aren't other open
    Pull Requests for the same
    update/change?
  • I have performed a self-review of my own code
  • I have made corresponding changes needed to the documentation

@itizarsa
Copy link
Copy Markdown
Contributor Author

itizarsa commented Apr 4, 2025

@Sorikairox One potential problem is that the description will be added to the response if the users don't have custom exception filters.

@Sorikairox
Copy link
Copy Markdown
Collaborator

@itizarsa I think it's ok, adding attributes shouldn't break existing integrations

@Sorikairox Sorikairox merged commit 0c029e8 into Savory:main Apr 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpException Message Format

2 participants