Skip to content

Move redstone signal functions off the main thread #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Martijnpold wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move redstone signal functions off the main thread #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/de/saschat/createcomputing/peripherals/handles/RedstoneHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,13 @@ public ComputerizedRedstoneLinkTile.LinkPair getHandle() throws LuaException {
return linkPair;
}

@LuaFunction(mainThread = true)
@LuaFunction(mainThread = false)
public final void setSignal(IArguments arguments) throws LuaException {
isOpen();
int value = arguments.getInt(0);
System.out.println("sx: " + value);
getHandle().provideSignal(value);
}
@LuaFunction(mainThread = true)
@LuaFunction(mainThread = false)
public final int getSignal(IArguments arguments) throws LuaException {
isOpen();
return getHandle().retrieveSignal();
Expand Down
6 changes: 5 additions & 1 deletion src/main/java/de/saschat/createcomputing/tiles/ComputerizedRedstoneLinkTile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ public static class LinkPair {

public boolean registered = false;

public boolean dirty = false;
public int sendSignal = 0;
public int recvSignal = 0;
ComputerizedRedstoneLinkTile parent;
Expand Down Expand Up @@ -218,13 +219,16 @@ public int retrieveSignal() {
private void dirty() {
if (parent.getLevel().isClientSide())
return;
if (dirty) return;
dirty = true;
parent.tasks.add(this::_dirty);
parent.setChanged();
}

private void _dirty() {
dirty = false;
transmit.notifySignalChange();
receive.notifySignalChange();
parent.setChanged();
}

private void setSignal(int i) {
Expand Down