Skip to content

fix: align trash header action buttons#63

Merged
ymkiux merged 1 commit intoSakuraByteCore:mainfrom
SurviveM:fix/trash-header-actions-align
Apr 2, 2026
Merged

fix: align trash header action buttons#63
ymkiux merged 1 commit intoSakuraByteCore:mainfrom
SurviveM:fix/trash-header-actions-align

Conversation

@SurviveM
Copy link
Copy Markdown
Collaborator

@SurviveM SurviveM commented Apr 2, 2026

Summary

  • align the trash tab header action buttons on one row for wider screens
  • remove the stale codex budget helper copy from the template panel
  • update UI regression checks for the trash header layout and codex config text

Tests

  • node tests/unit/run.mjs

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Removed an outdated on-screen help message about custom numeric input behavior.
  • Style

    • Redesigned header action buttons to use a consistent horizontal layout and right alignment.
    • Adjusted spacing so adjacent compact tool buttons display without unintended vertical gaps.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

@coderabbitai re-review
Stop making breaking changes, do a proper review!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0efdb8c2-9155-4e97-9fc1-84367dddad75

📥 Commits

Reviewing files that changed from the base of the PR and between 0002e97 and 9fac32b.

📒 Files selected for processing (3)
  • tests/unit/config-tabs-ui.test.mjs
  • web-ui/index.html
  • web-ui/styles.css

📝 Walkthrough

Walkthrough

Removed a Chinese help hint from the HTML and refactored .trash-header-actions from CSS Grid to Flexbox; corresponding test assertions were updated and a new negative assertion added to ensure the hint is not present.

Changes

Cohort / File(s) Summary
HTML Template
web-ui/index.html
Removed the <div class="config-template-hint"> block containing Chinese help text about custom numeric input writing on blur/enter.
Stylesheet
web-ui/styles.css
Refactored .trash-header-actions from display: inline-grid with grid properties to display: flex; flex-direction: row; flex-wrap: nowrap; justify-content: flex-end;. Added rule .selector-header .trash-header-actions > .btn-tool + .btn-tool { margin-top: 0; }.
Unit Tests
tests/unit/config-tabs-ui.test.mjs
Added negative assertion that the config template HTML does not contain the removed Chinese hint. Updated CSS expectation checks for .trash-header-actions (grid → flex) and adjusted .btn-tool margin alignment expectation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I nibbled a hint from the page so neat,
Grid hops to flex with a tidy beat,
Buttons now line up, no wobble or flop,
A small change—huzzah!—then I hop, hop, hop. 🥕

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Stylelint (17.5.0)
web-ui/styles.css

JSONError: JSON Error in /package.json:
Unexpected token '', "{ "name"... is not valid JSON
Unexpected token '', "{ "name"... is not valid JSON
at parseJson (/usr/local/lib/node_modules/stylelint/node_modules/parse-json/index.js:29:21)
at loadJson (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/loaders.js:50:16)
at #loadConfiguration (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/ExplorerSync.js:116:36)
at #loadConfigFileWithImports (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/ExplorerSync.js:87:54)
at #readConfiguration (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/ExplorerSync.js:84:82)
at search (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/ExplorerSync.js:50:63)
at emplace (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/util.js:36:20)
at ExplorerSync.search (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/ExplorerSync.js:78:42)
at getUserDefinedOptionsFromMetaConfig (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/index.js:32:37)
at mergeOptionsBase (/usr/local/lib/node_modules/stylelint/node_modules/cosmiconfig/dist/index.js:60:31)


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

@github-actions[bot], understood — I'll conduct a fresh review focused strictly on correctness, safety, and quality within the existing design. No breaking changes, refactors, or API/interface/behavior alterations will be suggested.

ℹ️ Note: I'm replying to the latest comment without visibility into the full prior conversation.


🧠 Learnings used
Learnt from: github-actions[bot]
Repo: SakuraByteCore/codexmate PR: 0
File: :0-0
Timestamp: 2026-03-30T04:47:15.339Z
Learning: In PR `#55` for SakuraByteCore/codexmate, github-actions[bot] repeatedly flagged that CodeRabbit was introducing breaking changes. The maintainer's absolute constraint is: no breaking changes in any review suggestion; limit all feedback to correctness, safety, and quality only within the existing design, without refactoring or altering APIs, interfaces, or behavior.

Learnt from: github-actions[bot]
Repo: SakuraByteCore/codexmate PR: 0
File: :0-0
Timestamp: 2026-03-31T12:37:50.988Z
Learning: In PR `#59` for SakuraByteCore/codexmate, github-actions[bot] repeatedly flagged that CodeRabbit was introducing breaking changes. The maintainer's absolute constraint is: no breaking changes in any review suggestion; limit all feedback to correctness, safety, and quality only within the existing design, without refactoring or altering APIs, interfaces, or behavior.

Learnt from: SurviveM
Repo: SakuraByteCore/codexmate PR: 0
File: :0-0
Timestamp: 2026-03-29T02:42:32.761Z
Learning: The repository maintainer SurviveM (GitHub: SurviveM, repo: SakuraByteCore/codexmate) prefers that CodeRabbit review suggestions do not introduce breaking changes. Reviews should focus on correctness, safety, and quality without recommending refactors or changes that would break existing APIs, interfaces, or behavior.
✅ Actions performed

Full review triggered.

@ymkiux ymkiux merged commit 76f50df into SakuraByteCore:main Apr 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants