Add better parsing for youtube embed links#534
Open
thundertheidiot wants to merge 2 commits intoSableClient:devfrom
Open
Add better parsing for youtube embed links#534thundertheidiot wants to merge 2 commits intoSableClient:devfrom
thundertheidiot wants to merge 2 commits intoSableClient:devfrom
Conversation
also introduces support for timestamps, playlists and youtube music links, tracking info is still stripped, embeds use the timestamp
3f7a3ee to
e72a40f
Compare
Contributor
Author
|
force push was just a reword of the commit |
dozro
reviewed
Mar 25, 2026
7w1
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the previous hacky regex method with a slightly better link parser. Add support for timestamps, playlists and youtube music links, tracking info is still stripped and embeds use the timestamp. Previously none of these features were supported, this might also be slightly more robust.
Type of change
Checklist:
AI disclosure: