Skip to content

Add better parsing for youtube embed links#534

Open
thundertheidiot wants to merge 2 commits intoSableClient:devfrom
thundertheidiot:youtube-cleanup
Open

Add better parsing for youtube embed links#534
thundertheidiot wants to merge 2 commits intoSableClient:devfrom
thundertheidiot:youtube-cleanup

Conversation

@thundertheidiot
Copy link
Contributor

Description

Replace the previous hacky regex method with a slightly better link parser. Add support for timestamps, playlists and youtube music links, tracking info is still stripped and embeds use the timestamp. Previously none of these features were supported, this might also be slightly more robust.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

also introduces support for timestamps, playlists and youtube music
links, tracking info is still stripped, embeds use the timestamp
@thundertheidiot
Copy link
Contributor Author

force push was just a reword of the commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants