Merged
Conversation
Contributor
|
can you run the formatter |
nickwitten
force-pushed
the
dev/nick/time-sub-bugfix
branch
from
614f128 to
0dd56b8
Compare
Contributor
Author
|
@guyfleeman can you also check this change to "connected_poll_loop" fn? I think this is desired to be "while" instead of "if." It seems to be fixing intermittent errors from kicker task complaining that radio communication is timing out: "Kicker Interface - Kicker task has stopped receiving commands from the radio task and will de-arm the kicker board" |
Contributor
|
yes your additional fix is valid |
guyfleeman
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sometimes the second Instant::now() is evaluated after the first Instant::now() which causes a panic