Conversation
also set the array node as parent instead of object for the items in that object when the object is in array
move from String to a 'Path' class
Switch adapters and callers to use the new Path object instead of raw strings, and implement Path utilities (splitToArrayString, improved add/goBack, fromString). Add JsonFunctions.getNodeFromPath/getChildren to resolve a JsonNode from a Path. Update MainActivity to create PathListAdapter with a Path and to refresh current node after navigating back. Add unit tests (PathTest) to cover splitToArrayString joining bug and path/goBack behavior. Also update .gitignore to exclude /core/bin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.