Skip to content

test cmake-based approach to run clang-tidy#254

Open
jacobmerson wants to merge 12 commits intoSCOREC:developfrom
jacobmerson:simpler-clang-tidy-workflow
Open

test cmake-based approach to run clang-tidy#254
jacobmerson wants to merge 12 commits intoSCOREC:developfrom
jacobmerson:simpler-clang-tidy-workflow

Conversation

@jacobmerson
Copy link
Collaborator

No description provided.

@jacobmerson
Copy link
Collaborator Author

Just experimenting to see if we can use this to get rid of the Bear step that is super slow. The initial test indicates that at least some files are not properly picking up the mpi.h header which is probably why we were using Bear in the first place...

…ly added due to the compiler wrapper. CMake code here is Claude output and is not suitable for merging as is, but fine for testing the theory.
@jacobmerson
Copy link
Collaborator Author

This approach seems to be significantly faster. Roughly 4 min 30 sec to run clang-tidy vs. 5 min 45sec for Bear + 9 min to run clang-tidy with the current workflow.

@jacobmerson jacobmerson force-pushed the simpler-clang-tidy-workflow branch from 1077156 to f8b821a Compare March 8, 2026 04:48
@jacobmerson jacobmerson marked this pull request as ready for review March 8, 2026 04:55
@jacobmerson jacobmerson requested review from Sichao25 and cwsmith March 8, 2026 04:56
@jacobmerson
Copy link
Collaborator Author

@Sichao25 @cwsmith Finally got this working without Bear. The strategy here has significant time savings with respect to running clang tidy because it avoids the use of Bear. The previous full clang-tidy step (including build pcms, etc.) is something like 16 minutes and this new one is 6m 30s.

Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@Sichao25 Sichao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants