add --ignore, --ignorefile options to CLI#124
Open
isaac-j-miller wants to merge 5 commits intoRyanZim:masterfrom
Open
add --ignore, --ignorefile options to CLI#124isaac-j-miller wants to merge 5 commits intoRyanZim:masterfrom
isaac-j-miller wants to merge 5 commits intoRyanZim:masterfrom
Conversation
added 2 commits
October 3, 2023 14:26
added 3 commits
October 3, 2023 14:53
Owner
|
Sorry, somehow this slipped through the cracks and I didn't get to reviewing until now. This PR adds 3 ways to ignore:
I'm not sure if I want all the added complexity of these 3 options. Additionally, I can see a few problems with the current implementations:
Accordingly, I'd suggest the following changes:
That said, I'm open to feedback if you disagree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
--ignoreoption, as well as an--ignore-fileoption. The patterns from the CLI input and loaded from the--ignore-filefiles passed from the CLI are merged and passed toglobbySync'signoreoption. If it exists,.ejslintignoreis loaded automatically.