Skip to content

[update] update remaining_duration after success try_seek#860

Merged
yara-blue merged 2 commits intoRustAudio:masterfrom
Keinsleif:fix/broken_take_by_seeking
Feb 28, 2026
Merged

[update] update remaining_duration after success try_seek#860
yara-blue merged 2 commits intoRustAudio:masterfrom
Keinsleif:fix/broken_take_by_seeking

Conversation

@Keinsleif
Copy link
Contributor

I don't really understand the total_duration calculation in TakeDuration, so there may be something odd in the code.

Fixes #859

@Keinsleif Keinsleif marked this pull request as ready for review February 28, 2026 09:06
Copy link
Member

@yara-blue yara-blue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! 🎉

@yara-blue yara-blue merged commit 0c8d942 into RustAudio:master Feb 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

try_seek on TakeDuration causes shift of truncated duration

2 participants