Open
Conversation
Firestar99
force-pushed
the
clang
branch
4 times, most recently
from
b66a59f to
72bd683
Compare
Firestar99
force-pushed
the
clang
branch
2 times, most recently
from
fe88ebd to
27c35d6
Compare
Firestar99
force-pushed
the
clang
branch
2 times, most recently
from
600e447 to
b8ac4f5
Compare
fee1-dead
reviewed
Apr 1, 2026
Comment on lines
121
to
-127
| if compiler.is_like_gnu() { | ||
| build | ||
| .flag("-Wall") | ||
| .flag("-Wextra") | ||
| .flag("-Wnon-virtual-dtor") | ||
| .flag("-Wno-missing-field-initializers") | ||
| .flag("-Wno-stringop-overflow") |
Contributor
There was a problem hiding this comment.
If is_like_gnu is telling a lie then i think there's something wrong?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wno-stringop-overflowCCXmakes thecccrate think it's still an msvc compiler instead of a clang / gcc compiler, so everything just fails.