Open
Conversation
…an alternative to (all) or (inventory) (#181) Co-authored-by: Christopher Riwik <criwik@sqli.com>
Can be used during the Mourning's End Part 1
* ci: Log which file is failing lint * ci: Make tsv-lint.sh script portable * devx: Add editorconfig to help editing .tsv files
* banks: Add Great Conch * agility: Add Great Conch Bank rocks
…Nemus Retreat) (#404) * This adds two missing Pendant of Ates teleport entries to teleportation_items.tsv, extending the existing numbered sequence directly after North Aldarin.
teleportation_portals_poh.tsv:83-85 — Fixed all 3 Marim Portal destination coordinates: 2798 2799 0 → 2797 2798 1 (matching the actual spell landing tile on plane 1) transports.tsv:5053-5062 — Added a new # Marim section with 8 staircase transport entries (4 pairs covering all 4 stair tile options you provided), each going bidirectionally between plane 0 and plane 1 BFS can now land at 2797 2798 1 via the portal, use one of the registered staircases to descend to plane 0, then walk to the bank at 2780 2783 0. The standard Ape Atoll Teleport spell (same destination) also benefits from the stair entries.
* add lumbridge castle basement goblins transports * add pre-quest mountain camp shortcut + remove quest req for going out * rename Cook's guild -> Cooking guild * add seer's village teleport spell * add elemental workshop entrance * add piscatoris falconry area * fix tsv linting issues * add trollweiss sled transports * add shadow dungeon transports * add piscatoris fishing colony transports * add sorcerer's tower transports * add cam torum entrance transports * add observatory tower & dungeon transports * fix observatory tower grapple shortcut requirements * add shilo village gem mine transports * add corsair cove dungeon transports and shortcuts * add myths' guild transports and portals * fix linting issues * fix typo * add brimhaven house medium clue step ladder * use explicit quest req for myth's guild top floor portals * add prifddinas' gates (fixes #363) * add river dougne canoes (part. fixes #399) * Added battered key to elemental workshop transports item requirements * Removed stair requirements, added steel key ring (assumes the key is on the ring)
…ocation; Map the missing ladder. (#398) * Add Ape Atoll Dungeon Portal to POH; Fix Arceuus Spellbook teleport location; Map the missing ladder. * fix lint issues * Fixed linting problem * Fixed more linting problems --------- Co-authored-by: Snappi <dwagom@snappi.quest> Co-authored-by: GedasFX <contact@gedas.dev>
- Add parser package: TsvParser, TransportRecord, FieldParser, WorldPointParser, SkillRequirementParser, ItemRequirementParser, QuestParser, VarCheckType, VarRequirement, VarRequirementParser - Add requirement package: ItemRequirement, TransportItems - Remove old model classes: TransportVarCheck, TransportVarbit, TransportVarPlayer, TransportItems (old) - Update Transport.java with builder pattern and TransportRecord constructor - Update TransportType with resourcePath, radiusThreshold, isTeleport() instance method, refine() - Update TransportLoader to use TsvParser - Update PathfinderConfig to use VarRequirement and ItemRequirement - Update overlays for isTeleport() instance method - Update all tests for new types
- Remove log item requirements from hot air balloon destinations (assumed in storage) - Fix Kastori quetzal unlock varbit in quetzals.tsv - Update TSV lint script to use header line for column count - Minor Pathfinder cleanup: make stats final, add @Getter for done, fix javadoc
* Centralize transport type configuration - Add TransportTypeConfig to manage enabled/cost state per TransportType - Add enabledGetter and costGetter functional fields to TransportType - Add override(TransportType, ...) convenience methods to ShortestPathPlugin - Replace individual boolean fields and if-else chain in PathfinderConfig.useTransport() with TransportTypeConfig lookups - Extract checkPohVariant, checkTeleportationItemRules, checkJewelleryBoxTier, remapPohTransports helper methods - Remove artificialTransportCosts EnumMap (costs from config via costGetter) - Remove testTeleportationBoxes (now gated by useTeleportationItems) - Add TransportTypeConfigTest * Refactor TransportType to add the config keys for enabled and cost * Refactor ShortestPathPlugin to use config keys form the enum for TransportType overrides
* Keep track of line numbers when parsing transports * Add coordinate exporter utility The coordinate exported can by executed by using the `dumpTransportCoordinates` gradle target. ``` ./gradlew dumpTransportCoordinates ``` The JSON output has four fields: * `id`: Stable identifier for this coordinate, will be used to identify new coordinates. * `label`: Human readable label * `coordinate`: The coordinate itself (x/y/p) * `source`: The source location for the coordinate. There are two arguments: * `--pretty`: Pretty-print the output JSON * `--output <FILE>`: Output the JSON to a file So far just transports are supported, adding support for destinations is left to a subsequent commit. * Add coordinate preview workflow This workflow computes the new coordinates which are added by a PR and then triggers the coordinate preview github action to display a preview of added or changed coordinates. Fixes #407 * Removed java changes for coordinate export * Refactor coordinate preview workflow to remove JDK dependency and add Python-based coordinate dumping * Update readme to reflect python change * Fixed header line (was missing a #) * Add Coordinate Dump and Preview workflows for PR coordinate management
…omments Two bugs fixed: 1. Script not found on older PR branches pull_request_target was checking out the PR head SHA, so PRs opened before check_tsv.py existed would error with 'file not found', causing the job to fail with no parseable output. Fix: drop the explicit ref — pull_request_target's default checkout is the base branch (master), so scripts always come from there. The PR's src/main/resources files are then overlaid via a separate git-fetch step. 2. Spurious '0 issues in 0 files' comment buildBody() was posting a failure comment whenever outcome != 'success', even when the script errored before producing any FAIL/ok lines. Fix: return null and skip the comment when failCount === 0.
Scripts (compute_changed_coordinates.sh, dump_transport_coordinates.py, diff_coordinate_json.py) were being loaded from the PR head because the checkout used an explicit ref. A malicious PR could modify them. Fix mirrors the CSV-lint approach: - Drop the explicit ref so pull_request_target checks out master by default. - Fetch refs/pull/<N>/head and overlay only src/main/resources, so we diff the contributor's data while keeping master's scripts. - Pass the fetched PR head SHA as a new optional arg to compute_changed_coordinates.sh so git merge-base still finds the correct common ancestor even though HEAD is now master.
) * Add a user-configurable selection of planted spirit trees in the config. We cannot reliably know which spirit trees are planted and which are not, but we can reliably have user tell that themselves. * fix lint issues * Updated VarBits for spirit trees * Initial * Optimize * Update spirit tree locations in transports file * lint * Clarify Spirit Tree logic in comments Updated comments for various Spirit Tree locations to clarify that planged Spirit Tree logic is handled by PathfinderConfig.isPlantedSpiritTreeAllowed, and varbits are not needed. * Fix typo in Spirit Tree comments * Add support for new menu. * add back logic --------- Co-authored-by: Snappi <dwagom@snappi.quest> Co-authored-by: GedasFX <contact@gedas.dev>
* Add Kathy Corkat Boat Add the boat run by Kathy Corkat that goes from Pisc to West of Gnome Stronghold * Update Kathy Corkat boat duration Update the boat duration for Kathy Corkat to 10 ticks * Add Buildable Mausoleum Bridge Add the buildable bridge west of Fenkenstrains Castle that goes to the Mausoleum * Modify Kathy Corkat's boat transportation Modify Kathy Corkat's boat transportation to account for payments being made directly from the bank
* Firstly add the Trellis object to the exclusion list when the collision map is computed. It is classified as a "door" otherwise and able to be routed through. * Add transports for the door which check the relevant quest is completed. * Add unit tests which check that without the quest a longer route is suggested. Fixes #266
* boats: Add rowboat to Angler's Retreat * ships: Add pandemonium/musa point/port sarim ship * banks: Add Pandemonium bank chest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason when I set a path it will randomly increase my RAM useage to 1.5gb. Even if i clear the path and log out it fills my ram to 1.5gb and my frames drop to 1fps. All other apps still working fine. This happens randomly, maybe 1 in 3 paths I set. Paths can be simple, no obsticles ect and short path.
not sure if it matters;
PC 16gb ddr4 ram, i7 10700k, 3070ti, 2t nvme ssd