Conversation
Contributor
Author
|
I'm going to push this through without approval because it's a complex process requiring common,js, common.css and app to all be updated & deployed in lock step together. Something in the MW 1.39 is causing odd JS behavior, and installing the libraries afresh resolves it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reliability and idempotent results we've preferred self-hosting js libraries ourselves rather than dynamically serving them from unpkg or similar.
However the process of manually doing this is tedious, and makes upgrading annoying.
This script is a middle ground. We keep serving the files but they are automatically fetched for us as build time. It also provides one place to keep a list of npm libraries we use.
Testing...
github tests are good. Tested locally, and then in prod.