Open
Conversation
Contributor
|
Several uncertainties about this PR, those being the power needed to destroy and the effective elements. Those seem somewhat hardcoded to a particular purpose and are potentially better off implemented as a TileState. However, I will need to see more about how they're being used. Can you link the code that uss these two members? Aside from that, it would be ideal to separate some of these changes into their own PRs: -Create a PR for the feature of hiding items behind objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add the ability for tiles to be instantly destroyed with Moves of certain types and power. Effects can be spawned when the tile is destroyed this way.
-Add an "Object" category for tiles. Objects cannot be passed through but can be attacked through, and items inside of an object are hidden until the object is destroyed.