Skip to content

fix: duplicate _von_#38

Open
grandeljay wants to merge 1 commit intoRobinTheHood:masterfrom
grandeljay:fix/duplicate-von
Open

fix: duplicate _von_#38
grandeljay wants to merge 1 commit intoRobinTheHood:masterfrom
grandeljay:fix/duplicate-von

Conversation

@grandeljay
Copy link
Contributor

image

The $from variable does not need to contain the von text:

if ($this->getVersion()) {
$from = ' von ' . $this->getVersion();
}

It's already written here:

$this->addMessage(
sprintf(
/** TRANSLATORS: %1$s: Module name. %2$s: Module current version. %3$s: Module new version. */
'%1$s benötigt ein Update von %2$s auf %3$s - Klicken Sie dafür beim Modul auf Update.',
$moduleName,
$from,
static::VERSION
)
);

This PR fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant