fix: complete HttpOnly cookie-based auth#23
Merged
VanessaBizzell merged 3 commits intomainfrom Feb 25, 2026
Merged
Conversation
Lock down current behavior for cookies, auth logic, and HTTP handlers so Phase 2 refactoring can proceed with confidence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- RefreshToken handler reads from HttpOnly cookie instead of JSON body, fixing the 15-minute logout bug (JS can't read HttpOnly cookies) - Login and ConfirmCode switch from GET+query params to POST+JSON body, preventing email/code exposure in logs and browser history - Add configurable RefreshPath to CookieConfig for projects mounting routes behind a prefix (defaults to "/auth/refresh") - Update all handler tests for new request formats Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Return 400 instead of panicking with index-out-of-range when a login request omits returnUrl and no ReturnUrls are configured. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
revitteth
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RefreshPathonCookieConfigfor projects mounting routes behind a prefix (defaults to/auth/refresh)ReturnUrlsconfig is empty and noreturnUrlis sentBreaking changes
POST /auth/login— was GET with query params, now POST with JSON body{"email": "...", "returnUrl": "..."}POST /auth/confirm— was GET with query params, now POST with JSON body{"code": "...", "email": "..."}POST /auth/refresh— readsrefresh_tokencookie automatically, no longer accepts{"token": "..."}in bodyTest plan
RefreshPathtests for set/clear cookiesReturnUrlsconfig panic guard testedgo test ./...passes (62 tests)🤖 Generated with Claude Code