feat: resolve Excalidraw embeds to exports#4
Open
Restuta wants to merge 1 commit intofeat/inline-image-publishingfrom
Open
feat: resolve Excalidraw embeds to exports#4Restuta wants to merge 1 commit intofeat/inline-image-publishingfrom
Restuta wants to merge 1 commit intofeat/inline-image-publishingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.excalidraw.mdembeds.svgand then raster fallbacksWhy
After PR 2, local image assets work, but Excalidraw embeds still publish as dead text because the actual renderable artifact is usually a sibling export, not the
.excalidraw.mdnote itself. This PR teaches pubmd how to bridge that gap without adding a full Excalidraw renderer.Verification
npm run verify![[chart.excalidraw.md]]plus a siblingchart.svg, then verifying the rendered page contained an actual<img>with an embedded data URL source while?raw=1still returned the original Excalidraw embed