Restcomm 2497: implement suspend account#2904
Open
ddhuy wants to merge 7348 commits intoRestComm:masterfrom
Open
Restcomm 2497: implement suspend account#2904ddhuy wants to merge 7348 commits intoRestComm:masterfrom
ddhuy wants to merge 7348 commits intoRestComm:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we can only update an account to
Closedstate, which means all related resources (DIDs, Clients etc) will be removed and Account will be inactive.From this state there is no way to get back to
Active.For this reason we need to implement the
Suspendedstate which means, Account and account's resources (DIDs, Clients etc) cannot operate but are not deleted. At any time aSuspendedaccount can move to eitherActiveorClosedstateWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2497
Special notes for your reviewer:
Following regression tests are added as @gsaslis recommend:
SUSPENDEDaccount. Account cannot login, create calls, search DID etc.CLOSEDstate or toACTIVEstate again.ACTIVEstate means that Account and sub-accounts are active and can be used again, same for all related resources.CLOSEDstate means that Account, sub-accounts and related resources are closed forever and will be never used again. External resources like, purchased DID number will be released (so no more costs) but everything else (account, sub-account, resources) will remain in the DB for audit purposes.