Decouple DispatchEngine from Router and improve type safety#173
Merged
alganet merged 1 commit intoRespect:masterfrom Mar 18, 2026
Merged
Decouple DispatchEngine from Router and improve type safety#173alganet merged 1 commit intoRespect:masterfrom
alganet merged 1 commit intoRespect:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
============================================
+ Coverage 97.87% 98.08% +0.20%
- Complexity 413 415 +2
============================================
Files 30 30
Lines 1036 1043 +7
============================================
+ Hits 1014 1023 +9
+ Misses 22 20 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduce RouteProvider interface so DispatchEngine depends on an abstraction rather than Router directly. Replace assert() calls in DispatchContext and RoutinePipeline by threading AbstractRoute as an explicit parameter. Fix AuthBasic to reject non-Basic auth schemes. Rename virtualHost to basePath. Add tests for Accept negotiation, DispatchEngine and RoutinePipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce RouteProvider interface so DispatchEngine depends on an abstraction rather than Router directly. Replace assert() calls in DispatchContext and RoutinePipeline by threading AbstractRoute as an explicit parameter. Fix AuthBasic to reject non-Basic auth schemes. Rename virtualHost to basePath. Add tests for Accept negotiation, DispatchEngine and RoutinePipeline.