Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Early return hides rolling deadline for grants without endDate
- Removed the early return guard clause and updated the component to handle missing endDate by treating it as active (rolling deadline), consistent with other components.
Or push these changes by commenting:
@cursor push e8a20c3426
Preview (e8a20c3426)
diff --git a/components/work/components/GrantStatusSection.tsx b/components/work/components/GrantStatusSection.tsx
--- a/components/work/components/GrantStatusSection.tsx
+++ b/components/work/components/GrantStatusSection.tsx
@@ -11,20 +11,9 @@
}
export const GrantStatusSection = ({ work }: GrantStatusSectionProps) => {
- // Handle missing deadline gracefully
- if (!work.note?.post?.grant?.endDate) {
- return (
- <div>
- <h3 className="text-base font-semibold text-gray-900 mb-2">Status</h3>
- <div className="flex items-center gap-2 text-gray-800 text-sm">
- <span className="h-2 w-2 rounded-full bg-gray-400 inline-block" />
- <span>Unknown</span>
- </div>
- </div>
- );
- }
-
- const endDate = new Date(work.note?.post?.grant?.endDate);
+ const endDate = work.note?.post?.grant?.endDate
+ ? new Date(work.note?.post?.grant?.endDate)
+ : null;
const isActive =
work.note?.post?.grant?.status === 'OPEN' &&
(work.note?.post?.grant?.endDate ? isDeadlineInFuture(work.note?.post?.grant?.endDate) : true);
@@ -40,7 +29,7 @@
</div>
{/* Rolling deadline for open grants */}
{isActive && <RollingDeadlineInfo className="mt-1" />}
- {!isActive && (
+ {!isActive && endDate && (
<div className="flex items-center gap-1 text-sm text-gray-600 mt-1">
<Clock size={14} className="text-gray-500" />
<span>| import { format } from 'date-fns'; | ||
| import { Clock } from 'lucide-react'; | ||
| import { isDeadlineInFuture } from '@/utils/date'; | ||
| import { RollingDeadlineInfo } from './RollingDeadlineInfo'; |
There was a problem hiding this comment.
Early return hides rolling deadline for grants without endDate
High Severity
When a grant has no endDate (which is the expected state for a rolling deadline), GrantStatusSection returns early showing "Unknown" status with a gray dot, and the RollingDeadlineInfo component is never rendered. In contrast, GrantDocument and GrantInfo both handle missing endDate correctly by treating the grant as active via endDate ? isDeadlineInFuture(endDate) : true. The sidebar status section is inconsistent and will show the wrong status for rolling deadline grants.
Additional Locations (1)
|
1 participant
Issue:
Users are messaging mods frequently asking about the Year 2099 deadlines for RFP's
Proposed Solution:
We should update this to just use terminology like "Rolling Deadline"
Note
Low Risk
Low risk UI-only change that adjusts how grant/RFP deadlines are communicated; no changes to application status logic or data handling.
Overview
Updates grant/RFP UI to stop showing specific “Closes {date}” deadlines for open grants and instead display a consistent “Rolling Deadline” indicator.
Introduces a reusable
RollingDeadlineInfocomponent (label + info tooltip) and wires it into the feed card (GrantInfo), grant document header (GrantDocument), and status section (GrantStatusSection), removing the prior close-date and “expiring soon” countdown messaging.Written by Cursor Bugbot for commit 3bd341a. This will update automatically on new commits. Configure here.